Content-Length: 381289 | pFad | http://github.com/rustls/rustls/pull/2915

9D Remove nested connection modules by djc · Pull Request #2915 · rustls/rustls · GitHub
Skip to content

Remove nested connection modules#2915

Open
djc wants to merge 2 commits intomainfrom
rm-connection-mods
Open

Remove nested connection modules#2915
djc wants to merge 2 commits intomainfrom
rm-connection-mods

Conversation

@djc
Copy link
Member

@djc djc commented Feb 11, 2026

No description provided.

@djc djc requested a review from ctz February 11, 2026 10:49
@rustls-benchmarking
Copy link

rustls-benchmarking bot commented Feb 11, 2026

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2419688 2399816 ✅ -19872 (-0.82%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9069868 8998091 -71777 (-0.79%) 0.97%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 49769874 49975601 205727 (0.41%) 0.48%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10391754 10433994 42240 (0.41%) 1.02%
handshake_session_id_1.2_no_crypto_client 1294468 1299598 5130 (0.40%) 1.82%
handshake_tickets_1.2_no_crypto_client 1373480 1378850 5370 (0.39%) 1.66%
handshake_session_id_1.3_no_crypto_client 2485328 2493092 7764 (0.31%) 2.22%
handshake_tickets_1.3_no_crypto_client 2489891 2497655 7764 (0.31%) 2.21%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 49756124 49895912 139788 (0.28%) 0.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 49593002 49731507 138505 (0.28%) 0.68%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 42344234 42446873 102639 (0.24%) 0.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 49605630 49704649 99019 (0.20%) 0.58%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11033331 11055186 21855 (0.20%) 1.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11060306 11081115 20809 (0.19%) 1.14%
handshake_no_resume_1.2_no_crypto_server 45681 45765 84 (0.18%) 0.51%
handshake_no_resume_1.3_no_crypto_server 67757 67870 113 (0.17%) 0.95%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 42367206 42435391 68185 (0.16%) 0.37%
handshake_session_id_ring_1.2_rsa_aes_client 3588662 3594422 5760 (0.16%) 0.64%
handshake_tickets_1.2_no_crypto_server 1359244 1361344 2100 (0.15%) 1.55%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 41097773 41160402 62629 (0.15%) 0.38%
handshake_tickets_ring_1.2_rsa_aes_client 3983467 3989467 6000 (0.15%) 0.65%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 49587614 49662043 74429 (0.15%) 0.45%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 49849172 49778009 -71163 (-0.14%) 0.44%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9018389 9030984 12595 (0.14%) 1.04%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 49798543 49866621 68078 (0.14%) 0.60%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4032946 4038196 5250 (0.13%) 0.53%
handshake_tickets_1.3_no_crypto_server 2300762 2303672 2910 (0.13%) 1.15%
handshake_session_id_1.3_no_crypto_server 2354336 2357306 2970 (0.13%) 0.99%
handshake_session_id_1.2_no_crypto_server 1196501 1198001 1500 (0.13%) 1.76%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4420112 4425602 5490 (0.12%) 0.43%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 41088853 41137717 48864 (0.12%) 0.35%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 41030632 41073933 43301 (0.11%) 0.34%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 42380273 42423850 43577 (0.10%) 0.42%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 42377296 42341193 -36103 (-0.09%) 0.32%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 49652024 49619680 -32344 (-0.07%) 0.71%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3274721 3276854 2133 (0.07%) 0.23%
handshake_no_resume_1.3_no_crypto_client 75526 75575 49 (0.06%) 0.62%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 49822204 49790518 -31686 (-0.06%) 0.54%
handshake_no_resume_1.2_no_crypto_client 63688 63727 39 (0.06%) 0.23%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 49813228 49841915 28687 (0.06%) 0.54%
handshake_tickets_ring_1.2_rsa_aes_server 4071926 4073996 2070 (0.05%) 0.52%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5033851 5036131 2280 (0.05%) 0.41%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 49541697 49563574 21877 (0.04%) 0.67%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3913884 3915564 1680 (0.04%) 0.89%
handshake_session_id_ring_1.2_rsa_aes_server 3479194 3480664 1470 (0.04%) 0.54%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 41110688 41094051 -16637 (-0.04%) 0.46%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 42361830 42345396 -16434 (-0.04%) 0.42%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 42385484 42399294 13810 (0.03%) 0.41%
handshake_session_id_ring_1.3_rsa_chacha_client 30702366 30709338 6972 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30705557 30712529 6972 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30712674 30719646 6972 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30794046 30801018 6972 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30797207 30804179 6972 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30804324 30811296 6972 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 30819907 30826879 6972 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30832983 30839955 6972 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30834326 30841298 6972 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 30892147 30899119 6972 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30905193 30912165 6972 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30906536 30913508 6972 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 49549906 49560161 10255 (0.02%) 0.49%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 41017857 41026138 8281 (0.02%) 0.41%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3792689 3792118 -571 (-0.02%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1479014 1479181 167 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 41010449 41014987 4538 (0.01%) 0.27%
handshake_session_id_ring_1.3_rsa_chacha_server 31783089 31786599 3510 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31808357 31811867 3510 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31812510 31816020 3510 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31905279 31908789 3510 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31930547 31934057 3510 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31934700 31938210 3510 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32081818 32085298 3480 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32084783 32088263 3480 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32103451 32106931 3480 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32184823 32188303 3480 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32187788 32191268 3480 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32206471 32209951 3480 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1241369 1241501 132 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1240192 1240321 129 (0.01%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57703973 57708531 4558 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57850983 57855549 4566 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 57850983 57855549 4566 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 57850983 57855549 4566 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57963464 57968030 4566 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57963549 57968115 4566 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57981566 57986132 4566 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 57899258 57903816 4558 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3275607 3275824 217 (0.01%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1476787 1476863 76 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92377063 92381629 4566 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92377063 92381629 4566 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92377063 92381629 4566 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92421704 92426270 4566 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92421789 92426355 4566 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92439806 92444372 4566 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2616761 2616639 -122 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 116930562 116935128 4566 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 116972263 116976829 4566 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1688450 1688506 56 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2623362 2623431 69 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2177850 2177892 42 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7188028 7188160 132 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2402781 2402820 39 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7189989 7190092 103 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2305314 2305342 28 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2310968 2310996 28 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11087084 11087216 132 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11092840 11092972 132 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3794713 3794751 38 (0.00%) 0.21%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46040020 46039660 -360 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10929657 10929740 83 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45849507 45849587 80 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 45915972 45916052 80 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 45916919 45916999 80 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 45917959 45918039 80 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46081632 46081712 80 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46082235 46082315 80 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46092480 46092560 80 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80152439 80152519 80 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80152772 80152852 80 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80152839 80152919 80 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80260192 80260272 80 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80262075 80262155 80 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80270400 80270480 80 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34716782 34716814 32 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104821943 104822023 80 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 104861579 104861659 80 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34718511 34718506 -5 (-0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.10 ms 1.06 ms ✅ -0.04 ms (-3.67%) 2.02%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.21 ms 1.18 ms ✅ -0.03 ms (-2.33%) 2.14%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.20 ms 1.18 ms ✅ -0.03 ms (-2.15%) 1.80%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_1.2_no_crypto 440.60 µs 456.88 µs 16.29 µs (3.70%) 6.82%
handshake_session_id_1.2_no_crypto 405.00 µs 416.98 µs 11.98 µs (2.96%) 7.02%
handshake_session_id_1.3_no_crypto 782.22 µs 797.59 µs 15.37 µs (1.97%) 5.40%
handshake_tickets_ring_1.2_rsa_aes 1.58 ms 1.61 ms 0.03 ms (1.75%) 2.84%
handshake_tickets_1.3_no_crypto 752.58 µs 765.08 µs 12.50 µs (1.66%) 6.00%
handshake_session_id_ring_1.2_rsa_aes 1.49 ms 1.51 ms 0.02 ms (1.20%) 2.29%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.72 ms 1.70 ms -0.02 ms (-1.01%) 1.94%
handshake_no_resume_1.3_no_crypto 89.69 µs 88.97 µs -0.72 µs (-0.81%) 11.35%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 8.03 ms 7.98 ms -0.04 ms (-0.51%) 2.10%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 8.22 ms 8.19 ms -0.04 ms (-0.45%) 1.88%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.55 ms 5.52 ms -0.02 ms (-0.39%) 4.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 7.35 ms 7.32 ms -0.02 ms (-0.33%) 1.89%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 8.03 ms 8.01 ms -0.03 ms (-0.32%) 1.66%
handshake_session_id_ring_1.3_rsa_chacha 6.10 ms 6.08 ms -0.02 ms (-0.32%) 1.44%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.23 ms 1.23 ms -0.00 ms (-0.30%) 1.36%
handshake_session_id_ring_1.3_ecdsap256_aes 5.64 ms 5.62 ms -0.02 ms (-0.30%) 1.83%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.60 ms 5.58 ms -0.02 ms (-0.29%) 1.52%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.35 ms 5.34 ms -0.02 ms (-0.28%) 4.62%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 7.55 ms 7.53 ms -0.02 ms (-0.28%) 1.83%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 8.23 ms 8.21 ms -0.02 ms (-0.26%) 1.79%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 8.05 ms 8.03 ms -0.02 ms (-0.25%) 1.95%
handshake_session_id_ring_1.3_rsa_aes 6.14 ms 6.13 ms -0.02 ms (-0.25%) 1.81%
handshake_no_resume_1.2_no_crypto 79.87 µs 80.05 µs 0.18 µs (0.22%) 12.13%
transfer_no_resume_1.2_no_crypto 12.00 ms 12.02 ms 0.03 ms (0.21%) 2.76%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.69 ms 8.68 ms -0.02 ms (-0.20%) 1.35%
handshake_tickets_ring_1.3_ecdsap384_aes 8.79 ms 8.77 ms -0.02 ms (-0.20%) 1.40%
handshake_tickets_ring_1.3_ecdsap256_aes 5.69 ms 5.68 ms -0.01 ms (-0.19%) 1.96%
handshake_tickets_ring_1.3_rsa_chacha 6.14 ms 6.13 ms -0.01 ms (-0.18%) 1.72%
handshake_no_resume_ring_1.3_ecdsap256_aes 468.15 µs 468.98 µs 0.82 µs (0.18%) 3.04%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.23 ms 1.23 ms -0.00 ms (-0.17%) 1.32%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 7.55 ms 7.57 ms 0.01 ms (0.16%) 1.99%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.64 ms 5.63 ms -0.01 ms (-0.16%) 1.86%
handshake_no_resume_ring_1.3_ecdsap256_chacha 465.34 µs 466.08 µs 0.74 µs (0.16%) 3.19%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.69 ms 5.68 ms -0.01 ms (-0.16%) 3.84%
handshake_session_id_ring_1.3_ecdsap384_aes 8.73 ms 8.71 ms -0.01 ms (-0.15%) 1.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 7.36 ms 7.37 ms 0.01 ms (0.14%) 2.08%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.74 ms 8.73 ms -0.01 ms (-0.13%) 1.46%
transfer_no_resume_ring_1.2_rsa_aes 6.08 ms 6.07 ms -0.01 ms (-0.13%) 3.93%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 8.24 ms 8.25 ms 0.01 ms (0.12%) 1.93%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.28 ms 14.26 ms -0.02 ms (-0.12%) 1.55%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 8.23 ms 8.22 ms -0.01 ms (-0.11%) 1.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 545.56 µs 544.96 µs -0.60 µs (-0.11%) 3.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 543.02 µs 542.51 µs -0.51 µs (-0.09%) 3.03%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.89 ms 1.89 ms -0.00 ms (-0.09%) 3.10%
handshake_tickets_ring_1.3_rsa_aes 6.19 ms 6.18 ms -0.01 ms (-0.08%) 1.93%
transfer_no_resume_ring_1.3_rsa_aes 6.17 ms 6.18 ms 0.00 ms (0.08%) 3.61%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.35 ms 16.34 ms -0.01 ms (-0.07%) 1.56%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.26 ms 13.25 ms -0.01 ms (-0.06%) 1.78%
handshake_no_resume_ring_1.3_rsa_aes 956.25 µs 955.70 µs -0.56 µs (-0.06%) 1.07%
transfer_no_resume_ring_1.3_rsa_chacha 13.75 ms 13.74 ms -0.01 ms (-0.06%) 1.84%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.57 ms 5.57 ms 0.00 ms (0.05%) 4.74%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.61 ms 13.62 ms 0.00 ms (0.04%) 1.99%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 8.04 ms 8.05 ms 0.00 ms (0.03%) 2.00%
handshake_no_resume_ring_1.3_rsa_chacha 958.99 µs 958.68 µs -0.31 µs (-0.03%) 1.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 14.30 ms 14.30 ms 0.00 ms (0.03%) 1.97%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.78 ms 8.78 ms -0.00 ms (-0.02%) 2.58%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.56 ms 0.00 ms (0.01%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 947.67 µs 947.77 µs 0.10 µs (0.01%) 1.42%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.56 ms -0.00 ms (-0.01%) 1.00%
transfer_no_resume_1.3_no_crypto 12.07 ms 12.07 ms 0.00 ms (0.01%) 2.71%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.88 ms 4.88 ms 0.00 ms (0.00%) 5.53%

Memory usage

Key:

  • ∑: sum usage for entire benchmark run
  • 🔝: peak usage
  • B: bytes
  • a: allocations

Significant differences

There are no significant memory usage differences

Additional information

Historical results

Checkout details:

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 88.16327% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.73%. Comparing base (3cbb413) to head (945327b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/quic.rs 85.79% 23 Missing and 2 partials ⚠️
rustls/src/conn/mod.rs 94.20% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2915      +/-   ##
==========================================
- Coverage   92.73%   92.73%   -0.01%     
==========================================
  Files          98       98              
  Lines       21753    21752       -1     
  Branches      615      615              
==========================================
- Hits        20172    20171       -1     
  Misses       1440     1440              
  Partials      141      141

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz
Copy link
Member

ctz commented Feb 12, 2026

Onboard with doing this, but it's going to cause some obnoxious conflicts elsewhere. Later?

@djc
Copy link
Member Author

djc commented Feb 12, 2026

Yup, makes sense. Will wait until after your stuff has landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctz ctz Awaiting requested review from ctz

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djc @ctz








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/rustls/rustls/pull/2915

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy