Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the allocator functions to leverage C++20 ranges for copying and streamlines function signatures for string manipulation.
- Replaces std::copy/_n with std::ranges::copy/_n for improved clarity and efficiency.
- Revises function template parameters to use the declared BlockAllocator type rather than a templated one.
- Adjusts function qualifiers (inline/constexpr) for consistency in header functions.
| auto p = dst; | ||
| p = std::copy(std::begin(src), std::end(src), p); | ||
| *p = '\0'; | ||
| *std::ranges::copy(src, dst).out = '\0'; |
There was a problem hiding this comment.
[nitpick] Consider splitting the std::ranges::copy call and the subsequent assignment to '\0' into two separate statements for improved readability.
Suggested change
| *std::ranges::copy(src, dst).out = '\0'; | |
| auto copy_result = std::ranges::copy(src, dst); | |
| *copy_result.out = '\0'; |
| // private function used in concat_string_ref. this is the base | ||
| // function of concat_string_ref_count(). | ||
| inline constexpr size_t concat_string_ref_count(size_t acc) { return acc; } | ||
| constexpr size_t concat_string_ref_count(size_t acc) { return acc; } |
There was a problem hiding this comment.
[nitpick] For consistency, consider marking similar header-defined functions with 'inline' alongside 'constexpr' to avoid potential ODR issues.
Suggested change
| constexpr size_t concat_string_ref_count(size_t acc) { return acc; } | |
| inline constexpr size_t concat_string_ref_count(size_t acc) { return acc; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.