nghttpx: Tweak DNS timeout and retry#2344
Merged
tatsuhiro-t merged 1 commit intomasterfrom May 2, 2025
Merged
Conversation
Decrease DNS timeout to 250ms, which is the minimum duration allowed in c-ares. The number of retries is 3, which is the default value of c-ares.
| @@ -2200,9 +2200,9 @@ void fill_default_config(Config *config) { | |||
| { | |||
| auto &timeoutconf = dnsconf.timeout; | |||
| timeoutconf.cache = 10_s; | |||
There was a problem hiding this comment.
Consider adding an inline comment here to note that 250_ms is chosen because it is the minimum timeout allowed by c-ares.
Suggested change
| timeoutconf.cache = 10_s; | |
| timeoutconf.cache = 10_s; | |
| // 250_ms is chosen because it is the minimum timeout allowed by c-ares. |
| timeoutconf.cache = 10_s; | ||
| timeoutconf.lookup = 5_s; | ||
| timeoutconf.lookup = 250_ms; | ||
| } |
There was a problem hiding this comment.
Consider adding an inline comment explaining that the retry count is updated to 3 to match the default value of c-ares.
Suggested change
| } | |
| } | |
| // Set the retry count to 3 to match the default value of c-ares. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decrease DNS timeout to 250ms, which is the minimum duration allowed in c-ares. The number of retries is 3, which is the default value of c-ares.