shrpx_http2_upstream: Adopt std::ranges#2349
Merged
tatsuhiro-t merged 1 commit intomasterfrom May 7, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Http2Upstream implementation to adopt std::ranges for iterator and copy operations.
- Replaces std::begin/std::end with std::ranges::begin/std::ranges::end for decoding the HTTP2 settings payload.
- Migrates from std::copy and util::copy_lit to std::ranges::copy for constructing the via header field.
Comments suppressed due to low confidence (2)
src/shrpx_http2_upstream.cc:117
- Ensure that the header is included (if not already present) to support the use of std::ranges functions.
auto settings_payload =
src/shrpx_http2_upstream.cc:1843
- [nitpick] Verify that 'via->value' and the string view literal ("sv") are fully supported by the current compiler and library version to avoid any compatibility issues.
p = std::ranges::copy(via->value, p).out;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.