Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the hex_to_uint_tbl declaration to use C++20’s constinit specifier for guaranteed initialization timing.
- Switches from
static constexprtoconstinit const autoonhex_to_uint_tbl - Aims to enforce initialization at program startup rather than rely on dynamic/static initialization order
| bool in_attr_char(char c); | ||
|
|
||
| static constexpr auto hex_to_uint_tbl = []() { | ||
| constinit const auto hex_to_uint_tbl = []() { |
There was a problem hiding this comment.
Without inline or static, this header-defined variable has external linkage and can violate the One Definition Rule when included in multiple translation units. Consider adding inline (e.g., inline constinit const auto) or restoring static to maintain internal linkage.
Suggested change
| constinit const auto hex_to_uint_tbl = []() { | |
| inline constinit const auto hex_to_uint_tbl = []() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.