gh-92332: Docs-only deprecation of typing.Text#92351
Merged
Merged
Conversation
AlexWaygood
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
hauntsaninja
reviewed
May 6, 2022
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Member
|
I'm going to merge this first in case we inadvertently miss the beta freeze cutoff. We can just fix up anything else in the docs if Jelle spots problems later. |
Member
Author
Thanks @Fidget-Spinner 😊 |
| .. deprecated:: 3.11 | ||
| Python 2 is no longer supported, and most type checkers also no longer | ||
| support type checking Python 2 code. Users should now use | ||
| :class:`str` instead of ``Text`` wherever possible. |
Member
There was a problem hiding this comment.
Could we add an explicit note here saying that removal is not currently planned? A "deprecated" note can make users think it will be removed soon.
Member
Author
There was a problem hiding this comment.
(For future readers of this PR):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92332