Add support for the x86_64h-apple-darwin target#108795
Merged
bors merged 2 commits intorust-lang:masterfrom Apr 20, 2023
Merged
Add support for the x86_64h-apple-darwin target#108795bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
These commits modify compiler targets. |
3 tasks
wesleywiser
approved these changes
Apr 20, 2023
Member
|
@bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 20, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#108795 (Add support for the x86_64h-apple-darwin target) - rust-lang#110558 (Add Call terminator to SMIR) - rust-lang#110565 (linkchecker: running from a directory separate from the book) - rust-lang#110599 (Remove an unused `&[Ty]` <-> `&[GenericArg]`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rust-lang/compiler-team#599 for MCP.
r? compiler-team
CC @BlackHoleFox who recently overhauled the apple target code in
rustc-target.Target Support Checklist
I'm the designated developer.
This uses the same naming conventions used for the other macOS targets (
-apple-darwin), combined with the convention used by LLVM for thex86_64htargets. LLVM's convention matches the architecture name used when invoking various tools such aslipo,arch, and (IMO) there's not really a compelling reason to depart from it.I don't think this is especially likely, although I suppose someone could mistake it for
x86_64-apple-darwin.👍
It does not.
It is.
There are no new dependencies that don't also apply to
x86_64-apple-darwin.This has the same requirements as the other macOS targets (e.g.
x86_64-apple-darwinand similar).No change here.
👍
👍
The standard library tests seem to pass.
Documentation is provided.
Noted. This target is nearly identical to
x86_64-apple-darwin, so this isunlikely to cause issues anyway.
👍
👍