Fix thread synchronization issues in @babel/register#17915
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61275 |
|
commit: |
liuxingbaoyu
commented
Mar 29, 2026
|
|
||
| constructor() { | ||
| super((action, payload) => { | ||
| this.#signal[0] = 0; |
Member
Author
There was a problem hiding this comment.
I still don't know why reusing SharedArrayBuffer is causing the problem. Would using Atomics.store help here?
Member
There was a problem hiding this comment.
Maybe, as Atomics.store has some ordering gurantees about how write operations happen. Not sure though.
nicolo-ribaudo
approved these changes
Mar 30, 2026
JLHwung
approved these changes
Mar 30, 2026
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 24, 2026
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 24, 2026
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 24, 2026
JLHwung
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 29, 2026
JLHwung
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 30, 2026
JLHwung
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 30, 2026
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2We have already applied the fix to
@babel/eslint-parser.Ref: #14541
https://github.com/babel/babel/actions/runs/23682460647/job/68996658460