feat: Adding JsonToProtoMessage.java by allenc3 · Pull Request #400 · googleapis/java-bigquerystorage

allenc3 · 2020-07-07T22:25:31Z

Added JsonToProtoMessage.java which can convert json data to protocol buffer data given the protocol buffer descriptor.

codecov · 2020-07-07T22:27:27Z

Codecov Report

Merging #400 into master will increase coverage by 0.79%.
The diff coverage is 96.96%.

@@             Coverage Diff              @@
##             master     #400      +/-   ##
============================================
+ Coverage     77.02%   77.82%   +0.79%     
- Complexity      576      623      +47     
============================================
  Files            55       56       +1     
  Lines          3391     3535     +144     
  Branches        193      234      +41     
============================================
+ Hits           2612     2751     +139     
- Misses          668      677       +9     
+ Partials        111      107       -4

Impacted Files	Coverage Δ	Complexity Δ
.../bigquery/storage/v1alpha2/JsonToProtoMessage.java	`96.96% <96.96%> (ø)`	`47.00 <47.00> (?)`
...ery/storage/v1beta1/BaseBigQueryStorageClient.java	`60.34% <0.00%> (-10.25%)`	`19.00% <0.00%> (ø%)`
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java	`80.60% <0.00%> (+0.23%)`	`33.00% <0.00%> (ø%)`
...rage/v1beta1/stub/BigQueryStorageStubSettings.java	`85.23% <0.00%> (+0.51%)`	`14.00% <0.00%> (ø%)`
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java	`43.90% <0.00%> (+2.43%)`	`10.00% <0.00%> (ø%)`
...gquery/storage/v1beta2/BaseBigQueryReadClient.java	`43.90% <0.00%> (+2.43%)`	`10.00% <0.00%> (ø%)`
...bigquery/storage/v1alpha2/BigQueryWriteClient.java	`58.57% <0.00%> (+5.71%)`	`28.00% <0.00%> (ø%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90bb713...1065d26. Read the comment docs.

...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java

...storage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessageTest.java

...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java

...storage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessageTest.java

...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java

Wilson720

Looks good to me

...storage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessageTest.java

...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java

...storage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessageTest.java

…repeated types are optional

… int32 for BQDate)

…elds check.

…f json fields <= # of proto fields

…y for loops.

…values first. This prevents catching unexpected JsonExceptions and blocking the actual error message.

google-cloud-bigquerystorage/pom.xml

...storage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessageTest.java

… JsonToProtoMessageTests

* test: attempt tests up to 3 times * chore: run formatter

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2020

allenc3 force-pushed the JsonToProtoMessage branch from 4b83d6a to f337999 Compare July 7, 2020 22:26

yirutang reviewed Jul 9, 2020

View reviewed changes

allenc3 force-pushed the JsonToProtoMessage branch 2 times, most recently from cba9d39 to 3ea5b56 Compare July 13, 2020 16:43

yirutang reviewed Jul 13, 2020

View reviewed changes

...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved

Wilson720 reviewed Jul 13, 2020

View reviewed changes

allenc3 force-pushed the JsonToProtoMessage branch from f601561 to a107c68 Compare July 14, 2020 17:27

yirutang reviewed Jul 15, 2020

View reviewed changes

Wilson720 reviewed Jul 16, 2020

View reviewed changes

allenc3 force-pushed the JsonToProtoMessage branch from 4e00901 to 4ffb726 Compare July 16, 2020 22:22

Wilson720 approved these changes Jul 17, 2020

View reviewed changes

...storage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessageTest.java Outdated Show resolved Hide resolved

yirutang reviewed Jul 17, 2020

View reviewed changes

yirutang approved these changes Jul 20, 2020

View reviewed changes

allenc3 added 15 commits July 21, 2020 11:37

feat: Finished JsonToProtoMessage, adding in tests

69e4d3c

Added more test cases

d9530a4

Draft version of JsonToProtoMessage

16dd0bb

Fixed float types in jsonTest.proto, and added a test that checks if …

87489a0

…repeated types are optional

Fix according to PR (added case insensitive feature, added support to…

ce5c045

… int32 for BQDate)

Update JsonToProtoMessage to fix allowUnknownField behavior

d3d3505

Fix according to PR, used case insensitive treeset for allowUnknownFi…

5c7afe9

…elds check.

Fixed according to PR

e552748

Fix test errors

1ae4ece

Change loopiing all proto fields to looping all json fields since # o…

cd3d5bf

…f json fields <= # of proto fields

Remove unuse variable

4804ea9

Remove unuse variable

7f27de6

Removed unnecessary set

46db080

Fixed according to PR, and added proto message empty test case.

df42473

Pushed for loop to be outside of the try catches to remove unnecessar…

155e5ff

…y for loops.

allenc3 added 3 commits July 21, 2020 11:37

Made tests based on self created protos

2d564a0

Fix jsonTest.proto

426b7fd

Changed throwing empty JsonException to checking for the type of the …

5a7c6b4

…values first. This prevents catching unexpected JsonExceptions and blocking the actual error message.

allenc3 force-pushed the JsonToProtoMessage branch from ece766a to 5a7c6b4 Compare July 21, 2020 16:38

allenc3 marked this pull request as ready for review July 21, 2020 17:12

stephaniewang526 reviewed Jul 21, 2020

View reviewed changes

google-cloud-bigquerystorage/pom.xml Outdated Show resolved Hide resolved

stephaniewang526 reviewed Jul 21, 2020

View reviewed changes

...storage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessageTest.java Outdated Show resolved Hide resolved

allenc3 added 3 commits July 21, 2020 12:41

Fix by specifying version in parent pom only and remove * imports for…

4966c53

… JsonToProtoMessageTests

Add in parent pom

ec1c463

Refactor parent pom

1065d26

stephaniewang526 approved these changes Jul 21, 2020

View reviewed changes

stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jul 21, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2020

stephaniewang526 merged commit 200da6d into googleapis:master Jul 21, 2020

shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023

test: attempt tests up to 3 times (googleapis#400)

5a4fd38

* test: attempt tests up to 3 times * chore: run formatter

Conversation

allenc3 commented Jul 7, 2020

Uh oh!

codecov bot commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wilson720 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

codecov bot commented Jul 7, 2020 •

edited

Loading