This repository was archived by the owner on Sep 26, 2023. It is now read-only.
chore(test): make it easier to debug failures in SettingsTest#994
Merged
igorbernstein2 merged 2 commits intogoogleapis:masterfrom Mar 31, 2020
Merged
chore(test): make it easier to debug failures in SettingsTest#994igorbernstein2 merged 2 commits intogoogleapis:masterfrom
igorbernstein2 merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
=========================================
Coverage 78.66% 78.66%
Complexity 1167 1167
=========================================
Files 204 204
Lines 5152 5152
Branches 413 413
=========================================
Hits 4053 4053
Misses 925 925
Partials 174 174Continue to review full report at Codecov.
|
vam-google
approved these changes
Mar 31, 2020
Contributor
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
I don't really understand what is going on here, but it is test-only and looks safe, so LGTM =)
Contributor
Author
|
Yea, this test is overly complicated. But I didn't want to rewrite it, just needed to get reasonable error messages so that I could finish #993 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's really difficult to debug failures in SettingsTest. If something goes out sync it just tells you the expectation is is unmet. This pr will tell you which attribute path is broken