Fix compilation for Delphi XE6#51
Open
GuilhermeAlecrim7K wants to merge 1 commit into
Open
Conversation
Contributor
|
I don't see the reason to make it compatible with old compilers since it is not a library but a tool. Anyone can use free Community Edition Delphi to compile it with recent version. |
Author
|
It allows for companies that have licenses only on older versions to be able to use this tool. This is specially common here in Brazil. Embarcadero doesn't allow Community Edition installations alongside with paid license installations. Besides, the changes are extremely simple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TNetEncoding.HTML.Encodecalls inHTMLCoverageReport.paswith a new privateHtmlEncodewrapper that conditionally falls back to aStringReplace-based implementation whenCompilerVersion < 28.0(pre-XE7), sinceSystem.NetEncodingseems to have been introduced in XE7.System.NetEncodingusesclause with{$IF CompilerVersion >= 28.0}so XE6 builds don't fail on the missing unit.constdeclaration inside a procedure body inCoverageConfigurationTest.pasinto a localvar, since inline constants in routine bodies are not supported by XE6.