Open
Conversation
Leynse
requested changes
Oct 31, 2025
Collaborator
Leynse
left a comment
Leynse
left a comment
There was a problem hiding this comment.
- I started adding the central scheme for ig already - can you check and finish?
| ee_ig = waveps | ||
| ! | ||
| restart=1 !TODO TL: CHECK > we need this turned on right now for IG... | ||
| !restart=1 !TODO TL: CHECK > we need this turned on right now for IG... |
Collaborator
Author
There was a problem hiding this comment.
do you have a simple test model for me to debug this?
Collaborator
Author
There was a problem hiding this comment.
double check
restart = .true. is the default (sfincs_snapwave.f90, line 706), and cannot be changed
so this code block never has any effect
| ! Actual determining of source term - every first sweep of iteration | ||
| ! | ||
| call determine_infragravity_source_sink_term(inner, no_nodes, ntheta, w, ds, prev, cg_ig, nwav, depth, zb, H, ee, ee_ig, eeprev, eeprev_ig, cgprev, ig_opt, alphaigfac, alphaig_local, beta_local, srcig_local) | ||
| call determine_infragravity_source_sink_term([msk==1], no_nodes, ntheta, w, ds, prev, cg_ig, nwav, depth, zb, H, ee, ee_ig, eeprev, eeprev_ig, cgprev, ig_opt, alphaigfac, alphaig_local, beta_local, srcig_local) |
Collaborator
There was a problem hiding this comment.
In VS debug mode get message "forrtl: warning (406): fort: (1): In call to DETERMINE_INFRAGRAVITY_SOURCE_SINK_TERM, an array temporary was created for argument #1
Probably not harmful, be should it be avoided?
Collaborator
Author
There was a problem hiding this comment.
we can also explicitly allocate an array for this. Now it goes on the stack
…apwave_sfincs # Conflicts: # source/src/snapwave/snapwave_solver.f90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapwave additions to sfincs code