convert long numbers to strings in response#131
Open
jwillinghalpern wants to merge 3 commits intomasterfrom
Open
convert long numbers to strings in response#131jwillinghalpern wants to merge 3 commits intomasterfrom
jwillinghalpern wants to merge 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a new
convertLongNumbersToStringsoption to Filemaker.create(). Setting this to true converts long numbers such as those produced by FileMaker'sGet(uuidNumber)andRandomfunctions into strings rather than returning scientific notation with reduced precision.This is the issue which prompted this feature: Luidog/node-red-contrib-filemaker#61. I haven't checked if fixing fms-api-client alone addresses the issue fully because I haven't tried this change with node red.
This part of the changed code felt a bit repetitive, not of a better way offhand though:
fms-api-client/src/models/client.model.js
Line 393 in a1453bf