feat: ability to embed into platform host projects#1799
Open
vmutafov wants to merge 6 commits intoNativeScript:mainfrom
Open
feat: ability to embed into platform host projects#1799vmutafov wants to merge 6 commits intoNativeScript:mainfrom
vmutafov wants to merge 6 commits intoNativeScript:mainfrom
Conversation
edusperoni
reviewed
Apr 2, 2024
Collaborator
There was a problem hiding this comment.
This file should be reverted
Collaborator
There was a problem hiding this comment.
revert to keep history clean
Comment on lines
+182
to
+207
| implementation "com.google.android.material:material:$androidXMaterialVersion" | ||
| implementation "androidx.appcompat:appcompat:$androidXAppCompatVersion" | ||
| implementation 'androidx.navigation:navigation-fragment-ktx:2.5.3' | ||
| implementation 'androidx.navigation:navigation-ui-ktx:2.5.3' |
Collaborator
There was a problem hiding this comment.
are these needed? It'd mean all apps now depend on material, androidx navigation and appcompat
Collaborator
There was a problem hiding this comment.
This file might need to be gitignored (NativeScriptActivity.java isn't currently committed into main)
Collaborator
There was a problem hiding this comment.
This file might need to be gitignored (NativeScriptApplication.java isn't currently committed into main)
NathanWalker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.