Conversation
|
It looks like we need to adjust the ownership of this file to allow merge ability to more folks. |
|
@infinisil, do you have the rights to click the button? I'm not expecting a review from Eelco or Valentin. |
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
It looks like we need to adjust the ownership of this file to allow merge ability to more folks.
Yeah, CODEOWNERS needs to match the list here (it's also mentioned just above the list), please update this.
@infinisil, do you have the rights to click the button? I'm not expecting a review from Eelco or Valentin.
I cannot merge unless I turn off the code owner review requirement, but that would circumvent the point. If neither @edolstra nor @fricklerhandwerk are maintaining this, then they shouldn't be code owners. Let's give them a week or so, otherwise we can remove them as code and calendar owners, I can merge PRs that only change the code owners file.
…cumentation file The situation of #217 with no merge happening because of incorrect paperwork -- even though it's just documenting a change that already happened -- is *ridiculous*. Let's fix that.
…cumentation file The situation of #217 with no merge happening because of incorrect paperwork -- even though it's just documenting a change that already happened -- is *ridiculous*. Let's fix that.
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
Made the required change myself now
|
As per #218 (comment), code owners aren't required to approve before merging anymore either, so we can merge this now. |
5 participants
Fixes: #192