lines-around-directive rule should replaced with padding-line-between…#2756
Draft
HemanthPaila wants to merge 1 commit intoairbnb:masterfrom
Draft
lines-around-directive rule should replaced with padding-line-between…#2756HemanthPaila wants to merge 1 commit intoairbnb:masterfrom
HemanthPaila wants to merge 1 commit intoairbnb:masterfrom
Conversation
ljharb
requested changes
Apr 2, 2023
Collaborator
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Make sure if your editor is set up to run prettier or any autoformatter, that you disable those - formatters should only be ran on a repo where the repo is set up to use one explicitly
| // https://eslint.org/docs/rules/array-bracket-newline | ||
| // TODO: enable? semver-major | ||
| 'array-bracket-newline': ['off', 'consistent'], // object option alternative: { multiline: true, minItems: 3 } | ||
| "array-bracket-newline": ["off", "consistent"], // object option alternative: { multiline: true, minItems: 3 } |
Collaborator
There was a problem hiding this comment.
please revert the unrelated and incorrect formatting (this guide requires JS to use single quotes)
Author
|
sir i am closing now and i will make PR again. |
Collaborator
|
Please reuse this one, and do not create a new one. |
ljharb
force-pushed
the
HemanthPaila-Fixed
branch
from
da606cc to
1764d53
Compare
This was referenced Apr 2, 2023
anandfresh
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lines-around-directiverule should replaced withpadding-line-between-statements#2689