Add function to find a TopMenu Item#1944
Open
Ilusion9 wants to merge 5 commits intoalliedmodders:masterfrom
Open
Add function to find a TopMenu Item#1944Ilusion9 wants to merge 5 commits intoalliedmodders:masterfrom
Ilusion9 wants to merge 5 commits intoalliedmodders:masterfrom
Conversation
Member
|
It looks like you may have forgotten to include the header change |
Member
|
The function needs to be added to the public ITopMenu interface too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be used to change the logic of TopMenu items (find item -> remove -> create again) registered by base plugins (basecommands for example). I will use this to change the logic for sm_who (instead of flags, I will display their groups) so I don't have to modify basecommands whenever its updated.