refactor(core): add actionable hydration mismatch hints#68529
Open
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
Open
refactor(core): add actionable hydration mismatch hints#68529SkyZeroZx wants to merge 1 commit intoangular:mainfrom
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
Conversation
Adds targeted hints for known browser HTML normalization cases that alter the DOM before Angular hydration. Closes angular#56392
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds targeted hints for known browser HTML normalization cases that alter the DOM before Angular hydration.
Closes #56392
What is the current behavior?
Currently, the message may be somewhat generic and not indicate the real or complete cause of the problem.
What is the new behavior?
Missing explicit
<tbody>Spec :
When a
<tr>is written directly under<table>, the parser cancreate the missing table body section before Angular hydrates.
See: https://html.spec.whatwg.org/multipage/syntax.html#optional-tags
Missing explicit
<colgroup>Spec :
When a
<col>is written directly under<table>, the parser cancreate the missing column group before Angular hydrates.
See: https://html.spec.whatwg.org/multipage/syntax.html#optional-tags
Nested anchors
Spec:
Parser:
Nested links are invalid and the parser can close/restructure the
outer anchor before Angular hydrates.
See: https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-a-element
See: https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inbody
Block content inside
<p>Spec :
The parser closes the paragraph before inserting the block, so
the block becomes a sibling instead of a child.
See: https://html.spec.whatwg.org/multipage/grouping-content.html#the-p-element
Nested buttons
Spec :
Parser:
When the parser sees the inner
<button>, it closes the currentbutton first, so the buttons become siblings instead of nested nodes.
See: https://html.spec.whatwg.org/multipage/form-elements.html#the-button-element
See: https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inbody