[ty] Remove is_positive flag from predicates#23244
Closed
Conversation
sharkdp
added
do-not-merge
Typing conformance resultsNo changes detected ✅ |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownprefect
sphinx
trio
flake8
|
|
Contributor
|
Oh nice, this cleanup was less involved than I feared. |
sharkdp
force-pushed
the
david/is_positive_flag
branch
from
afd8239 to
d559bb0
Compare
sharkdp
changed the title
is_positive flag from predicates
Contributor
Author
|
Looks like a small performance regression, unfortunately. |
AlexWaygood
reviewed
Feb 12, 2026
Comment on lines
75
to
78
| #[derive(Clone, Copy, Debug, Hash, PartialEq, Eq, salsa::Update, get_size2::GetSize)] | ||
| pub(crate) struct Predicate<'db> { | ||
| pub(crate) node: PredicateNode<'db>, | ||
| pub(crate) is_positive: bool, | ||
| } |
Member
There was a problem hiding this comment.
it seems like there's not really any point having a separate Predicate struct at all with this refactor -- could we just use PredicateNode directly everywhere where we're currently using Predicate?
Contributor
Author
There was a problem hiding this comment.
Yeah, I know. I noticed that. That's why this is still in draft — I was just curious what the benchmarks would say.
Member
There was a problem hiding this comment.
That's why this is still in draft
ahhh, sorry! 😶
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan