Only verify MAX_ARG limit when running privileged.#391
Open
brown wants to merge 1 commit intocontainers:mainfrom
Open
Only verify MAX_ARG limit when running privileged.#391brown wants to merge 1 commit intocontainers:mainfrom
brown wants to merge 1 commit intocontainers:mainfrom
Conversation
|
Can one of the admins verify this patch?
|
|
I don’t see why the reason for the hardening would only apply to privileged bwrap. |
If bubblewrap has no special permissions compared to the process executing it, then it makes no sense since the process could just do what the unprivileged bubblewrap would do if it disregarded the limit. |
|
What if the data bubblewrap is parsing is the problem (i.e. untrusted), not the program passing it through? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've hit the MAX_ARG limit. There doesn't seem to be any reason for it when bwrap is unprivileged.