fix(bigquery): Enable list inference for parquet loads in offline_write_batch#6365
Open
Jwrede wants to merge 1 commit intofeast-dev:masterfrom
Open
fix(bigquery): Enable list inference for parquet loads in offline_write_batch#6365Jwrede wants to merge 1 commit intofeast-dev:masterfrom
Jwrede wants to merge 1 commit intofeast-dev:masterfrom
Conversation
…te_batch When pushing features with array/list types (e.g. STRING_LIST) to BigQuery via offline_write_batch, the data arrives as empty arrays because BigQuery's parquet loader does not infer list structure by default. Set parquet_options.enable_list_inference = True on the LoadJobConfig so array columns are written correctly. Fixes feast-dev#5845 Signed-off-by: Jonathan Wrede <wrede.jonathan00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[]) whenenable_list_inferenceis not set onParquetOptionsparquet_options.enable_list_inference = Trueto theLoadJobConfiginoffline_write_batchso list-typed features (e.g.STRING_LIST,INT32_LIST) are preserved when pushed viaPushMode.OFFLINEorPushMode.ONLINE_AND_OFFLINELoadJobConfighas the correctparquet_optionsFixes
Fixes #5845
Test plan
test_offline_write_batch_enables_list_inferencepasses