Open
Conversation
When starting a pipeline from S3 checkpoint, if a local checkpoint is available, we prefer it if it has made more progress than the remote checkpoint. Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
mihaibudiu
reviewed
Feb 12, 2026
Contributor
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
Which line checks that the local one is preferred?
I think a comment explaining this would be nice.
Updates the description to mention that we will prefer the checkpoint that has made more progress between the latest remote and the latest local checkpoint. Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
mihaibudiu
approved these changes
Feb 12, 2026
lalithsuresh
requested changes
Feb 12, 2026
| if chk_uuid is not None: | ||
| assert UUID(uuid) >= UUID(chk_uuid) | ||
|
|
||
| if not clear_storage: |
Contributor
There was a problem hiding this comment.
Do we have tests covering a few cases here? E.g., local but no remote, local only, remote only, local ahead of remote, local == remote, and local behind remote?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting a pipeline from S3 checkpoint, if a local checkpoint is available, we prefer it if it has made more progress than the remote checkpoint.