fix(settings): make certification tables full width#67185
Open
Sembauke wants to merge 1 commit intofreeCodeCamp:mainfrom
Open
fix(settings): make certification tables full width#67185Sembauke wants to merge 1 commit intofreeCodeCamp:mainfrom
Sembauke wants to merge 1 commit intofreeCodeCamp:mainfrom
Conversation
github-actions
Bot
added
the
platform: learn
|
This also affects the timeline table. Before: Today: |
Sembauke
force-pushed
the
codex/full-width-certification-tables
branch
2 times, most recently
from
aa9b298 to
d795270
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.What changed
The certification settings tables now explicitly render as full-width tables inside
.certification-settings.Why
The global table styles make tables scrollable inline blocks. In the certification settings view, that allowed shorter certification tables to collapse to their content width, so sections no longer lined up visually.
Screenshots
Actual local
/settingsscreenshots captured from the running app athttp://localhost:8000/settingswith the certified user. The before screenshot applies the previous table display rule to the actual page for comparison.Before:
After:
Testing
pnpm exec stylelint client/src/components/settings/certification.css/settings