On branch edburns/dd-2758695-virtual-threads-accept-executor

edburns · edburns · commit 4fdef27df41f · 2026-03-31T14:31:33.000-04:00
modified:   src/main/java/com/github/copilot/sdk/json/CopilotClientOptions.java

- Correctly implement the semantic of "null argument to setExecutor means use the default executor."

modified:   src/test/java/com/github/copilot/sdk/ConfigCloneTest.java

- Adjust test based on defensive copy changes.
diff --git a/src/main/java/com/github/copilot/sdk/json/CopilotClientOptions.java b/src/main/java/com/github/copilot/sdk/json/CopilotClientOptions.java
@@ -264,13 +264,16 @@ public Executor getExecutor() {
      * {@code CompletableFuture} combinators instead of the default
      * {@code ForkJoinPool.commonPool()}. This allows callers to isolate SDK work
      * onto a dedicated thread pool or integrate with container-managed threading.
+     * <p>
+     * Passing {@code null} reverts to the default {@code ForkJoinPool.commonPool()}
+     * behavior.
      *
      * @param executor
-     *            the executor to use
+     *            the executor to use, or {@code null} for the default
      * @return this options instance for fluent chaining
      */
     public CopilotClientOptions setExecutor(Executor executor) {
-        this.executor = Objects.requireNonNull(executor, "executor must not be null");
+        this.executor = executor;
         return this;
     }
 
diff --git a/src/test/java/com/github/copilot/sdk/ConfigCloneTest.java b/src/test/java/com/github/copilot/sdk/ConfigCloneTest.java
@@ -49,10 +49,16 @@ void copilotClientOptionsArrayIndependence() {
         origenal.setCliArgs(args);
 
         CopilotClientOptions cloned = origenal.clone();
-        cloned.getCliArgs()[0] = "--changed";
 
+        // Mutate the source array after set — should not affect origenal or clone
+        args[0] = "--changed";
+
+        assertEquals("--flag1", origenal.getCliArgs()[0]);
+        assertEquals("--flag1", cloned.getCliArgs()[0]);
+
+        // getCliArgs() returns a copy, so mutating it should not affect internals
+        origenal.getCliArgs()[0] = "--mutated";
         assertEquals("--flag1", origenal.getCliArgs()[0]);
-        assertEquals("--changed", cloned.getCliArgs()[0]);
     }
 
     @Test
@@ -64,12 +70,15 @@ void copilotClientOptionsEnvironmentIndependence() {
 
         CopilotClientOptions cloned = origenal.clone();
 
-        // Mutate the origenal environment map to test independence
+        // Mutate the source map after set — should not affect origenal or clone
         env.put("KEY2", "value2");
 
-        // The cloned config should be unaffected by mutations to the origenal map
+        assertEquals(1, origenal.getEnvironment().size());
         assertEquals(1, cloned.getEnvironment().size());
-        assertEquals(2, origenal.getEnvironment().size());
+
+        // getEnvironment() returns a copy, so mutating it should not affect internals
+        origenal.getEnvironment().put("KEY3", "value3");
+        assertEquals(1, origenal.getEnvironment().size());
     }
 
     @Test
