Add quantities for "homeless" constants#363
Open
crystal-growth wants to merge 3 commits intoiliekturtles:masterfrom
Open
Add quantities for "homeless" constants#363crystal-growth wants to merge 3 commits intoiliekturtles:masterfrom
crystal-growth wants to merge 3 commits intoiliekturtles:masterfrom
Conversation
crystal-growth
changed the title
crystal-growth
force-pushed
the
add_quantities_for_constants
branch
4 times, most recently
from
9365611 to
0d6a7b1
Compare
…avitation, Stafan-Boltzmann fix
crystal-growth
force-pushed
the
add_quantities_for_constants
branch
from
0d6a7b1 to
18a0c13
Compare
Owner
|
Also skipping past this one for the moment. I'm hesitant to add quantities like this just to house constants. I'd like to see more thought on this/#32 before merging something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new quantities:
The tests will fail untill ElectricPermittivity from Add ElectricPermittivity with related units. #332 is merged.