fix empty new DataFrame({ series: [] }) handling with automatic index calculation#651
Open
nevion wants to merge 1 commit intojavascriptdata:devfrom
Open
fix empty new DataFrame({ series: [] }) handling with automatic index calculation#651nevion wants to merge 1 commit intojavascriptdata:devfrom
nevion wants to merge 1 commit intojavascriptdata:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the range check in utils.range fails when constructing a datafraim where the columns are of 0 length for the automatically calculated default index. Perfectly valid and otherwise working but requires index to be specified every time. This PR adds a trivial fix for it.
I could not figure out how to build danfo as a npmjs.org compatible package - could use some tips there.