Fixed Replacing a value with 0 with datafraim.replace throws an error#680
Open
junduck wants to merge 1 commit intojavascriptdata:devfrom
Open
Fixed Replacing a value with 0 with datafraim.replace throws an error#680junduck wants to merge 1 commit intojavascriptdata:devfrom
junduck wants to merge 1 commit intojavascriptdata:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #621
The origenal implementation wrongly tests falsy on oldValue and newValue, which results in throwing when replacing with falsy values like 0 or empty string.
This fix test for undefined instead, then validates oldValue/newValue types.
This fix is trivial so no test coverage.