pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/ookii-dialogs/ookii-dialogs-wpf/pull/2

a469e846088cc1bf.css" /> Fixed InitialFolder so it now works more than first time its called p… by buildcomplete · Pull Request #2 · ookii-dialogs/ookii-dialogs-wpf · GitHub
Skip to content

Fixed InitialFolder so it now works more than first time its called p…#2

Open
buildcomplete wants to merge 1 commit intoookii-dialogs:masterfrom
buildcomplete:buildcomplete-patch-nitial-directory
Open

Fixed InitialFolder so it now works more than first time its called p…#2
buildcomplete wants to merge 1 commit intoookii-dialogs:masterfrom
buildcomplete:buildcomplete-patch-nitial-directory

Conversation

@buildcomplete
Copy link

@buildcomplete buildcomplete commented Apr 10, 2019

The dialog.SetDefaultFolder(item) is only set first time the applications sets the folder,
Next time the folder will be restored to last picked object and the 'Default folder' is ignored
Use instead dialog.SetFolder which behaviour better matches the name 'InitialFolder'

@buildcomplete
Fixed InitialFolder so it now works more than first time its called p…
aba8217 
…r. application

The dialog.SetDefaultFolder(item) is only set first time the applications sets the folder,
Next time the folder will be restored to last picked object and the 'Default folder' is ignored
Use instead dialog.SetFolder which behaviour better matches the name 'InitialFolder'
@buildcomplete buildcomplete mentioned this pull request Apr 10, 2019
Closed
@buildcomplete
Copy link
Author

buildcomplete commented Apr 10, 2019

Regarding the behaviour:

In our Application the user specifies many different filetypes, so dependant on the category we restore the default directory or last used for the category in either filepickers or folderpicker... therefore we need this functionality.

we have code like this many places in our application

var path = WpfShellDialogs.UserOpenFile(
    "*.xml",
    "Prediction model (.xml)|*.xml",
    FolderProvider.GetLastOrDefaultFolder(FolderProvider.FolderName.PredictionModel));

Maybe a better fix would be something like

  • InitialDirectory = DefaultDirectory (I would rename but to keep the interface maybe not renaming the Method is better) => InitialDirectory = behaviour from before patch
  • add a SelectedDirectory for filepickers so it is possible to owerwrite the behaviour and thus have more control ourself

@augustoproiete augustoproiete self-assigned this Apr 15, 2019
@augustoproiete augustoproiete mentioned this pull request Oct 4, 2019
Open
@augustoproiete augustoproiete changed the base branch from master to develop October 29, 2020 04:19
@augustoproiete augustoproiete self-requested a review as a code owner October 29, 2020 04:19
@augustoproiete augustoproiete changed the base branch from develop to master November 15, 2020 03:05
@augustoproiete augustoproiete force-pushed the master branch 4 times, most recently from f6f2131 to de84c47 Compare December 28, 2020 00:17
@CLAassistant
Copy link

CLAassistant commented Jun 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustoproiete augustoproiete Awaiting requested review from augustoproiete augustoproiete is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@augustoproiete augustoproiete

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@buildcomplete @CLAassistant @augustoproiete
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.




Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy