Issue #1353, fixed NullCall in GetProjectByUuidDatabaseAction.java#1368
Open
LordofthePickle wants to merge 1 commit intoopensourceBIM:masterfrom
Open
Conversation
…ction.java In this commit, a new query method was added to DatabaseSession.java which returns a hashmap of an IdEObject value with a UUID key (this allows for a faster run time via using HashMap.contains() and allows for the use of this query with other IdEObjects). In GetProjectByUuidDatabaseAction.java, logic was added to execute the new queryUuid() method while also performing authorization checks. Reported-By: zaqifathis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is aimed towards fixing Issue #1353. In it, two files are changed, DatabaseSession.java and GetProjectByUuidDatabaseAction.java. The former introduces a new queryUuid() method which follows the previous query() method; however, it maps the IdEObject value to a uuid key (this is aimed to improve the O time complexity by allowing for the use of .contains within a hashmap in GetProjectByUuidDatabaseAction.execute()). Furthermore, if wanted, this function can also be used for other objects if one needs to query for a uuid mapping. In the latter, logic is added to call this new queryUuid() method, perform authentication checks, make a uuid comparison to find a potential match, and throw an exception if something goes wrong (i.e. authentication, project not found, or invalid input).