Fix #20068 - Fix HTML special chars encoding on triggers and events#20080
Merged
williamdes merged 2 commits intophpmyadmin:masterfrom Feb 17, 2026
Merged
Fix #20068 - Fix HTML special chars encoding on triggers and events#20080williamdes merged 2 commits intophpmyadmin:masterfrom
williamdes merged 2 commits intophpmyadmin:masterfrom
Conversation
Signed-off-by: Bryan Hoffman <bryanhoffman1@gmail.com>
Signed-off-by: Bryan Hoffman <bryanhoffman1@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20080 +/- ##
============================================
+ Coverage 62.44% 63.51% +1.06%
- Complexity 16013 16044 +31
============================================
Files 678 679 +1
Lines 59847 59910 +63
============================================
+ Hits 37373 38051 +678
+ Misses 22474 21859 -615
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
williamdes
changed the title
williamdes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Newbie here just trying to learn how this all works. Sorry, I obviously don't know what I'm doing! I thought I saw I was supposed to submit pull requests to the QA branch, but I just got an email saying that I should do it for the master branch. I am trying to learn and I gave my best shot at solving issue #20068
Fixes #20068
Added ENT_NOQUOTES flag to htmlspecialchars so single and double quotes are ignored. The change should remain secure, as I understand that <textarea> is only vulnerable to a </textarea> in its contents, but single and double quotes will be fine.
Signed-off-by: Bryan Hoffman bryanhoffman1@gmail.com