Thanks for the PR!

Could you please just change the key parts and pull out the refactoring into a new PR? That would make the review a bit easier.

This PR currently introduces the ability to customize the alignment for image display by adding a third parameter to the image_show function. Here’s a breakdown of key considerations:

1. Parameter Type Selection: Using Offset Instead of Alignment
Offset was chosen for the new parameter because it provides more granular control over image placement than an alignment setting would allow. This gives greater flexibility to the Lua API.

2. Using Table for the Lua API image_show's 3rd Parameter
   Instead of creating a specific Lua type for Offset, a Table was used instead. Implementing a custom type would add complexity, and with limited familiarity with mlua, the added benefit of this approach was unclear.

3. Not Choosing ratatui::layout::Offset
ratatui::layout::Offset relies on i32, which would add unnecessary complexity here, as x and y are initially defined from the top-left corner of the preview area.

4. Location of Offset Definition
   Placing the Offset definition in yazi-adapter instead of yazi-shared makes it easier to interact with the global PREVIEW variable.

5. Using Option<Offset> as the image_show's 3rd Parameter Type
   Alignment requires the sizes of both the image and max, but this information is unavailable at the time Default::default is called. Therefore, Option<Offset> was used, as implementing Default for Offset is impractical in this case.

6. Calling Offset::from in Multiple Places Instead of Exclusively in image_show of adapter.rs
   Similar to the 5th point, while max’s size is available here, the image size remains unknown at this stage, making it impractical to use Offset::from. Even if we were to extract image_area from image_show, avoid exposing image_area, and pass the data it returns to image_show — using image_area’s result to compute the offset in the meantime — it would make the signatures of different image_show functions inconsistent and introduce extra complexity, which could negate the benefits of calling Offset::from in adapter.rs.

7. Lua’s Access to Image Size
   While allowing Lua access to image size would enable custom image placement logic (avoiding workarounds like in mediainfo.yazi and improving mixed previews for similar plugins), it could lead to redundant calculations when applying the resulting size to display the image. Since the purpose of obtaining the image size is for custom placement, one possible solution is for Lua to pass a function to Rust: Lua would provide mapping logic for the image and preview area sizes, which Rust would apply, resulting in an offset for display. However, it is unclear whether this approach is feasible, especially in an async environment, and the potential cost is also uncertain.

Next Steps

Open to feedback on improving specific implementation details or considering alternative approaches.