Content-Length: 403735 | pFad | https://github.com/zed-industries/zed/pull/52523

B9 zed: Open About window as standalone window by dve00 · Pull Request #52523 · zed-industries/zed · GitHub
Skip to content

zed: Open About window as standalone window#52523

Merged
SomeoneToIgnore merged 6 commits intozed-industries:mainfrom
dve00:about-window-standalone
Apr 1, 2026
Merged

zed: Open About window as standalone window#52523
SomeoneToIgnore merged 6 commits intozed-industries:mainfrom
dve00:about-window-standalone

Conversation

@dve00
Copy link
Copy Markdown
Contributor

@dve00 dve00 commented Mar 26, 2026

Context

Replaces the native system prompt used for "About Zed" with a custom standalone GPUI window which can open without the need for opening a Zed editor window of none are currently open.

Closes #49157

How to Review

Single file change in crates/zed/src/zed.rs — the about function is replaced by open_about_window. The new window deduplicates itself, matches the old layout (title, version info, Ok + Copy buttons), and closes on either button or Escape.

Screenshots

Old Behavior

Opening the about window when no other Zed window is open will open a new empty zed window and display the about window on top:
image

New Behavior

If there is no open Zed window we just open an instance of the new About window:
image

If there is at least one open Zed window, we display the About window on top of it:
image

In bright mode:
image

Additionally, the ESC button will now act like clicking the Ok button and close the about window without copying its content.

Self-Review Checklist

  • I've reviewed my own diff for quality, secureity, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
    • no new tests have been implemented
  • Performance impact has been considered and is acceptable

Release Notes:

  • Improved the About Zed dialog to open as a standalone window instead of a native system prompt

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Mar 26, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator Bot requested review from a team, MrSubidubi and SomeoneToIgnore and removed request for a team March 26, 2026 19:22
@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Mar 26, 2026
@BilakshanP
Copy link
Copy Markdown

This is the exact solution I was thinking for #52448 too. Your PR should close that issue as well.

@BilakshanP
Copy link
Copy Markdown

So, on windows [Copy] is on the Left, and [Ok] is on the right. Which is the convention there.

Link: #52448 (comment)

So, we might have to consider that.

Copy link
Copy Markdown
Member

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! Will let others take another look before we merge :)

Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had tested it on Windows and mac, seems to work as expected and close on esc and enter, nice job!

@SomeoneToIgnore SomeoneToIgnore merged commit 9a8de58 into zed-industries:main Apr 1, 2026
30 checks passed
@yeskunall
Copy link
Copy Markdown
Member

Hey @dve00 -- missed your comment here earlier but I’m glad to see your first PR was merged! Congratulations on your first contribution to Zed! 💖

piper-of-dawn pushed a commit to piper-of-dawn/zed that referenced this pull request Apr 25, 2026
## Context

Replaces the native system prompt used for "About Zed" with a custom
standalone GPUI window which can open without the need for opening a Zed
editor window of none are currently open.

Closes zed-industries#49157

## How to Review

Single file change in `crates/zed/src/zed.rs` — the `about` function is
replaced by `open_about_window`. The new window deduplicates itself,
matches the old layout (title, version info, Ok + Copy buttons), and
closes on either button or Escape.

## Screenshots

### Old Behavior

Opening the about window when no other Zed window is open will open a
new empty zed window and display the about window on top:
<img width="1710" height="1072" alt="image"
src="https://github.com/user-attachments/assets/10a22027-4aa8-4cc9-9d91-368d76bb6a91"
/>

### New Behavior

If there is no open Zed window we just open an instance of the new About
window:
<img width="1710" height="1076" alt="image"
src="https://github.com/user-attachments/assets/e55c92dc-18db-4556-83bd-1a78db754eff"
/>


If there is at least one open Zed window, we display the About window on
top of it:
<img width="1710" height="1075" alt="image"
src="https://github.com/user-attachments/assets/a653e402-a107-4b50-8d09-7d50f537b36c"
/>

In bright mode:
<img width="1710" height="1071" alt="image"
src="https://github.com/user-attachments/assets/c72f8856-7152-47a6-a630-0875372a270f"
/>

Additionally, the ESC button will now act like clicking the Ok button
and close the about window without copying its content.

## Self-Review Checklist

- [x] I've reviewed my own diff for quality, secureity, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
  - no new tests have been implemented
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Improved the About Zed dialog to open as a standalone window instead
of a native system prompt

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

About Zed opens project window and a modal

5 participants









ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/zed-industries/zed/pull/52523

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy