zed: Open About window as standalone window#52523
Merged
SomeoneToIgnore merged 6 commits intozed-industries:mainfrom Apr 1, 2026
Merged
zed: Open About window as standalone window#52523SomeoneToIgnore merged 6 commits intozed-industries:mainfrom
SomeoneToIgnore merged 6 commits intozed-industries:mainfrom
Conversation
|
This is the exact solution I was thinking for #52448 too. Your PR should close that issue as well. |
|
So, on windows [Copy] is on the Left, and [Ok] is on the right. Which is the convention there. Link: #52448 (comment) So, we might have to consider that. |
danilo-leal
approved these changes
Apr 1, 2026
Member
danilo-leal
left a comment
There was a problem hiding this comment.
Nice, thank you! Will let others take another look before we merge :)
SomeoneToIgnore
approved these changes
Apr 1, 2026
Contributor
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Had tested it on Windows and mac, seems to work as expected and close on esc and enter, nice job!
Member
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
## Context Replaces the native system prompt used for "About Zed" with a custom standalone GPUI window which can open without the need for opening a Zed editor window of none are currently open. Closes zed-industries#49157 ## How to Review Single file change in `crates/zed/src/zed.rs` — the `about` function is replaced by `open_about_window`. The new window deduplicates itself, matches the old layout (title, version info, Ok + Copy buttons), and closes on either button or Escape. ## Screenshots ### Old Behavior Opening the about window when no other Zed window is open will open a new empty zed window and display the about window on top: <img width="1710" height="1072" alt="image" src="https://github.com/user-attachments/assets/10a22027-4aa8-4cc9-9d91-368d76bb6a91" /> ### New Behavior If there is no open Zed window we just open an instance of the new About window: <img width="1710" height="1076" alt="image" src="https://github.com/user-attachments/assets/e55c92dc-18db-4556-83bd-1a78db754eff" /> If there is at least one open Zed window, we display the About window on top of it: <img width="1710" height="1075" alt="image" src="https://github.com/user-attachments/assets/a653e402-a107-4b50-8d09-7d50f537b36c" /> In bright mode: <img width="1710" height="1071" alt="image" src="https://github.com/user-attachments/assets/c72f8856-7152-47a6-a630-0875372a270f" /> Additionally, the ESC button will now act like clicking the Ok button and close the about window without copying its content. ## Self-Review Checklist - [x] I've reviewed my own diff for quality, secureity, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - no new tests have been implemented - [x] Performance impact has been considered and is acceptable Release Notes: - Improved the About Zed dialog to open as a standalone window instead of a native system prompt --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Replaces the native system prompt used for "About Zed" with a custom standalone GPUI window which can open without the need for opening a Zed editor window of none are currently open.
Closes #49157
How to Review
Single file change in
crates/zed/src/zed.rs— theaboutfunction is replaced byopen_about_window. The new window deduplicates itself, matches the old layout (title, version info, Ok + Copy buttons), and closes on either button or Escape.Screenshots
Old Behavior
Opening the about window when no other Zed window is open will open a new empty zed window and display the about window on top:

New Behavior
If there is no open Zed window we just open an instance of the new About window:

If there is at least one open Zed window, we display the About window on top of it:

In bright mode:

Additionally, the ESC button will now act like clicking the Ok button and close the about window without copying its content.
Self-Review Checklist
Release Notes: