mir-opt and custom target fixes by onur-ozkan · Pull Request #119619 · rust-lang/rust

onur-ozkan · 2024-01-05T14:34:25Z

Could you please test the last two commits from https://github.com/onur-ozkan/rust/commits/panic-abort-mir-opt when you have the time? The first commit should resolve the error of using the nightly flag with a stable compiler, and the second one should resolve the custom target issue.

I tested with the two commits and the errors of using nightly flag and custom target specs were not seen.
Testing was completed for the test suites like ui, run-pass-valgrind, coverage, mir-opt, codegen, assembly, incremental.

Fixes #115642

rustbot · 2024-01-05T14:34:33Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

onur-ozkan · 2024-01-05T14:34:57Z

@rustbot author (still testing)

onur-ozkan · 2024-01-06T11:52:45Z

@rustbot ready

onur-ozkan · 2024-01-06T13:00:58Z

@rustbot author (will add another commit for handling #115642 (comment))

onur-ozkan · 2024-01-07T21:38:03Z

@rustbot ready

src/bootstrap/src/core/build_steps/synthetic_targets.rs

Signed-off-by: onur-ozkan <work@onurozkan.dev>

oli-obk · 2024-01-08T15:04:37Z

@bors r+ rollup

bors · 2024-01-08T15:04:40Z

📌 Commit b888e2f has been approved by oli-obk

It is now in the queue for this repository.

onur-ozkan · 2024-01-08T16:50:56Z

(accidentally pushed some changes on this branch, then reverted it)

onur-ozkan · 2024-01-08T16:57:33Z

@bors r=oli-obk

bors · 2024-01-08T16:57:35Z

📌 Commit b888e2f has been approved by oli-obk

It is now in the queue for this repository.

…oli-obk mir-opt and custom target fixes From rust-lang#115642 (comment) > > Could you please test the last two commits from https://github.com/onur-ozkan/rust/commits/panic-abort-mir-opt when you have the time? The first commit should resolve the error of using the nightly flag with a stable compiler, and the second one should resolve the custom target issue. > I tested with the two commits and the errors of using nightly flag and custom target specs were not seen. Testing was completed for the test suites like ui, run-pass-valgrind, coverage, mir-opt, codegen, assembly, incremental. Fixes rust-lang#115642

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#117744 (Add -Zuse-sync-unwind) - rust-lang#118649 (Make inductive cycles in coherence ambiguous always) - rust-lang#118979 (Use `assert_unsafe_precondition` for `char::from_u32_unchecked`) - rust-lang#119562 (Rename `pointer` field on `Pin`) - rust-lang#119619 (mir-opt and custom target fixes) - rust-lang#119632 (Fix broken build for ESP IDF due to rust-lang#119026) - rust-lang#119712 (Adding alignment to the cases to test for specific error messages.) - rust-lang#119734 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#117744 (Add -Zuse-sync-unwind) - rust-lang#118649 (Make inductive cycles in coherence ambiguous always) - rust-lang#118979 (Use `assert_unsafe_precondition` for `char::from_u32_unchecked`) - rust-lang#119619 (mir-opt and custom target fixes) - rust-lang#119632 (Fix broken build for ESP IDF due to rust-lang#119026) - rust-lang#119712 (Adding alignment to the cases to test for specific error messages.) - rust-lang#119734 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#119619 - onur-ozkan:panic-abort-mir-opt, r=oli-obk mir-opt and custom target fixes From rust-lang#115642 (comment) > > Could you please test the last two commits from https://github.com/onur-ozkan/rust/commits/panic-abort-mir-opt when you have the time? The first commit should resolve the error of using the nightly flag with a stable compiler, and the second one should resolve the custom target issue. > I tested with the two commits and the errors of using nightly flag and custom target specs were not seen. Testing was completed for the test suites like ui, run-pass-valgrind, coverage, mir-opt, codegen, assembly, incremental. Fixes rust-lang#115642

onur-ozkan · 2024-01-09T16:56:26Z

Each commit in this PR addresses an issue that also exists in the beta release.

@rustbot label +beta-accepted

cc @rust-lang/bootstrap

Mark-Simulacrum · 2024-01-09T22:06:57Z

(Adding beta-nominated. Please follow the beta backport process, or PRs will get missed: https://forge.rust-lang.org/release/backporting.html)

[beta] backports - mir-opt and custom target fixes rust-lang#119619 - Update LLVM submodule rust-lang#119802 r? ghost

rustbot assigned oli-obk Jan 5, 2024

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 5, 2024

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 6, 2024

onur-ozkan marked this pull request as ready for review January 6, 2024 11:53

onur-ozkan mentioned this pull request Jan 6, 2024

Rust building and testing fails while bootstrapping it in poky #115642

Closed

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 7, 2024

oli-obk reviewed Jan 8, 2024

View reviewed changes

src/bootstrap/src/core/build_steps/synthetic_targets.rs Show resolved Hide resolved

onur-ozkan added 3 commits January 8, 2024 16:07

enable RUSTC_BOOTSTRAP on panic=abort mir-opt test

8aa7dd0

Signed-off-by: onur-ozkan <work@onurozkan.dev>

detect user-specified custom targets in compiletest

26c71cb

Signed-off-by: onur-ozkan <work@onurozkan.dev>

fix the incorrect target on stage1 ui-fulldeps tests

b888e2f

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the panic-abort-mir-opt branch from e7fc441 to b888e2f Compare January 8, 2024 13:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2024

onur-ozkan force-pushed the panic-abort-mir-opt branch 2 times, most recently from d0afa02 to b888e2f Compare January 8, 2024 16:48

matthiaskrgr mentioned this pull request Jan 8, 2024

Rollup of 8 pull requests #119755

Closed

matthiaskrgr mentioned this pull request Jan 9, 2024

Rollup of 7 pull requests #119760

Merged

bors merged commit 985b2ce into rust-lang:master Jan 9, 2024

rustbot added this to the 1.77.0 milestone Jan 9, 2024

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 9, 2024

Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 9, 2024

cuviper mentioned this pull request Jan 11, 2024

[beta] backports #119861

Merged

cuviper modified the milestones: 1.77.0, 1.76.0 Jan 11, 2024

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 11, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2024

Auto merge of rust-lang#119861 - cuviper:beta-next, r=cuviper

048e898

[beta] backports - mir-opt and custom target fixes rust-lang#119619 - Update LLVM submodule rust-lang#119802 r? ghost

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2024

Auto merge of rust-lang#119861 - cuviper:beta-next, r=cuviper

f732c37

[beta] backports - mir-opt and custom target fixes rust-lang#119619 - Update LLVM submodule rust-lang#119802 r? ghost

Uh oh!

Conversation

onur-ozkan commented Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 5, 2024

Uh oh!

onur-ozkan commented Jan 5, 2024

Uh oh!

onur-ozkan commented Jan 6, 2024

Uh oh!

onur-ozkan commented Jan 6, 2024

Uh oh!

onur-ozkan commented Jan 7, 2024

Uh oh!

Uh oh!

oli-obk commented Jan 8, 2024

Uh oh!

bors commented Jan 8, 2024

Uh oh!

onur-ozkan commented Jan 8, 2024

Uh oh!

onur-ozkan commented Jan 8, 2024

Uh oh!

bors commented Jan 8, 2024

Uh oh!

onur-ozkan commented Jan 9, 2024

Uh oh!

Mark-Simulacrum commented Jan 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

onur-ozkan commented Jan 5, 2024 •

edited

Loading