Skipping verbose diagnostic suggestions when calling .as_ref() on type not implementing AsRef#90399
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 30, 2021
Merged
Conversation
added 2 commits
October 29, 2021 15:49
rust-highfive
added
the
S-waiting-on-review
yuvaldolev
changed the title
yuvaldolev
changed the title
estebank
approved these changes
Oct 29, 2021
Contributor
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
I'm ok with the changes. Can you check the one nitpick? If I'm wrong, ping me and I'll merge as is.
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit cad2d21 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2021
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#90156 (Remove underlines from non-top docblocks.) - rust-lang#90183 (Show all Deref implementations recursively) - rust-lang#90202 (Improve and test cross-crate hygiene) - rust-lang#90375 (Use `is_global` in `candidate_should_be_dropped_in_favor_of`) - rust-lang#90399 (Skipping verbose diagnostic suggestions when calling .as_ref() on type not implementing AsRef) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #89806
Skipping suggestions when calling
.as_ref()for types that do not implement theAsReftrait.r? @estebank