allow enabling features for deps with --features#2876
allow enabling features for deps with --features#2876bors merged 1 commit intorust-lang:masterfrom bennofs:fix-2851
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
tests/features.rs
Outdated
There was a problem hiding this comment.
Could you update these to with_status(101) and an assertion about what stderr should be as well?
There was a problem hiding this comment.
Should I also update the first one (the build failure one)? Because asserting what stderr should be for that one will depend on rustc compiler output, which makes the test a little bit fragile, no?
There was a problem hiding this comment.
I'd add with_status(101) but yeah we should avoid asserting much about the compiler's exact output
There was a problem hiding this comment.
ok, force-pushed a new commit that fixes this.
|
Thanks @bennofs! |
allow enabling features for deps with --features Fixes #2851
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
4 participants
Fixes #2851