cargo fetch: Display workspace warnings.#7243
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 13, 2019
Merged
Conversation
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors: r+ |
Contributor
|
📌 Commit 22619a2 has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 22619a2 with merge 070def1b21826b61c376c9e1a28173be1c4d18ac... |
Contributor
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Contributor
Author
|
@bors retry |
bors
added
S-waiting-on-bors
Contributor
bors
added a commit
that referenced
this pull request
Aug 13, 2019
`cargo fetch`: Display workspace warnings. Warnings were previously hidden with `cargo fetch`. It may be a little confusing, so go ahead and display them. cc #7180 (comment) I thought about other commands that don't display warnings, but I couldn't think of any others where it would be useful. The only edge case is `publish`/`package`, which won't display unused key warnings because the manifest is rewritten and they are stripped. But displaying warnings there is awkward because some warnings will be displayed twice.
Contributor
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warnings were previously hidden with
cargo fetch. It may be a little confusing, so go ahead and display them.cc #7180 (comment)
I thought about other commands that don't display warnings, but I couldn't think of any others where it would be useful. The only edge case is
publish/package, which won't display unused key warnings because the manifest is rewritten and they are stripped. But displaying warnings there is awkward because some warnings will be displayed twice.