Content-Length: 344101 | pFad | https://github.com/rust-lang/rust/pull/36951

7D Fix an ICE in BuildReducedGraphVisitor::visit_trait_item. by nnethercote · Pull Request #36951 · rust-lang/rust · GitHub
Skip to content

Comments

Fix an ICE in BuildReducedGraphVisitor::visit_trait_item.#36951

Merged
bors merged 1 commit intorust-lang:masterfrom
nnethercote:fix-ICE
Oct 4, 2016
Merged

Fix an ICE in BuildReducedGraphVisitor::visit_trait_item.#36951
bors merged 1 commit intorust-lang:masterfrom
nnethercote:fix-ICE

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Oct 4, 2016 •
edited
Loading

This ICE occurs in the futures-rs-test-all benchmark in rustc-benchmarks (fixes #36950).

@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 4, 2016

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@nnethercote
Fix an ICE in BuildReducedGraphVisitor::visit_trait_item.
7857903 
This ICE occurs in the futures-rs-test-all benchmark in
rustc-benchmarks.
@eddyb
Copy link
Member

eddyb commented Oct 4, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 4, 2016

📌 Commit 7857903 has been approved by eddyb

@nnethercote
Copy link
Contributor Author

nnethercote commented Oct 4, 2016

Thanks to @eddyb for telling me how to fix this!

@Manishearth Manishearth mentioned this pull request Oct 4, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 4, 2016
@Manishearth
Rollup merge of rust-lang#36951 - nnethercote:fix-ICE, r=eddyb
177aabd 
Fix an ICE in BuildReducedGraphVisitor::visit_trait_item.

This ICE occurs in the futures-rs-test-all benchmark in rustc-benchmarks (fixes rust-lang#36950).
bors added a commit that referenced this pull request Oct 4, 2016
@bors
Auto merge of #36953 - Manishearth:rollup, r=Manishearth
4a9af01 
Rollup of 12 pull requests

- Successful merges: #36798, #36878, #36902, #36903, #36908, #36916, #36917, #36921, #36928, #36938, #36941, #36951
- Failed merges:
@bors bors merged commit 7857903 into rust-lang:master Oct 4, 2016
@nnethercote nnethercote deleted the fix-ICE branch October 4, 2016 21:51
@jseyfried jseyfried mentioned this pull request Oct 4, 2016
Closed
@jseyfried
Copy link
Contributor

jseyfried commented Oct 4, 2016

@nnethercote Thanks! That ICE was my fault (introduced in #3660).
Also, this PR fixes #36943.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arielb1 arielb1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE building futures-rs-all-test from rustc-benchmarks

6 participants

@nnethercote @rust-highfive @eddyb @bors @jseyfried @arielb1








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/rust-lang/rust/pull/36951

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy